Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTC-3084: Add new endpoints that proxy to geostore microservice (for now) #621

Draft
wants to merge 31 commits into
base: develop
Choose a base branch
from
Draft

GTC-3084: Add new endpoints that proxy to geostore microservice (for now) #621

wants to merge 31 commits into from
+3,010 −2,237

Conversation

dmannarino
Copy link
Member

@dmannarino dmannarino commented Jan 17, 2025 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@dmannarino
Bump deps to allow building
99a0ce0
@dmannarino
Proxy the first two RW API requests
511ad16
@dmannarino
Only Pydantic models suitable as route return values
912121c
@dmannarino
More routes
c54cd43
@dmannarino
Add endpoint to proxy to RW for getting geostores by land use and index
11d35e2
@dmannarino
Fix a typo; add proxy route to get a geostore by wdpa_id
1248f79
@dmannarino
Add RW endpoint to get a view link for a geostore by id
250a865
@dmannarino
Add proxy to RW route to find geostores by ids
5484f69
@dmannarino
Add proxy to RW endpoint calculating geostore area
6154d1a
@dmannarino
For geostore by wpaid: Run through (new) Pydantic models; pass along …
361f425 
…API key if provided
@dmannarino
Fix broken imports and bbox type declaration
e0fa91b
@dmannarino
Fix loading of RW response
3cb3afd
@dmannarino
Add missing geojson attribute to RWGeostoreAttributes
a3b8bb4
@dmannarino
WIP: Add initial RW proxy tests (1 passes, 1 fails)
c09c20a
@dmannarino
WIP: Comment-out failing test for the moment in order to get to deploy
ae3fb51
@dmannarino
Fix RW geostore-by-land-use proxy; rearrange RW response models to re…
490d02e 
…flect actual order of objects returned
@dmannarino
Fix up RW geostore boundary proxy functions
67299e4
@dmannarino
Fix RW proxy to admin list endpoint, add models
41526af
@dmannarino
Fix RW proxy for get_view_geostore_by_id endpoint; linting
bbe82e4
@dmannarino
Fix RW proxied geostore calc area endpoint
5c0ab0b
@dmannarino
Fix RW proxied geostore find-by-ids endpoint
1c2ae72
@dmannarino
Make name optional for RWAdminListItem
5cd5e08
@dmannarino
Fix copy pasta mistake for find_by_ids
8e63c8c
@dmannarino
Fix dropping payload and post->get in find-by-ids, calc area function…
6dff707 
…s; implement proxying add geostore route
@dmannarino
Fix URL for create_rw_geostore; implement proxy to RW get geostore en…
af18197 
…dpoint
@dmannarino
Improve RWAdminListResponse to omit missing name attribute
2707a21
@dmannarino
Fix detection of UUID param
a1da0c0
@dmannarino
Remove unnecessary parameter
be7b8e3
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.73123% with 112 lines in your changes missing coverage. Please review.

Project coverage is 79.99%. Comparing base (dd0616e) to head (b2ad219).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
app/utils/rw_api.py 12.87% 88 Missing ⚠️
app/routes/geostore/geostore.py 57.14% 24 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #621      +/-   ##
===========================================
- Coverage    81.07%   79.99%   -1.09%     
===========================================
  Files          130      130              
  Lines         5876     6117     +241     
===========================================
+ Hits          4764     4893     +129     
- Misses        1112     1224     +112
Flag Coverage Δ
unittests 79.99% <55.73%> (-1.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmannarino @codecov-commenter